On Wed, Mar 14, 2018 at 01:33:32PM +0100, Lukas Wunner wrote: > On Wed, Mar 14, 2018 at 02:05:47PM +0200, Mika Westerberg wrote: > > On Wed, Mar 14, 2018 at 12:48:49PM +0100, Rafael J. Wysocki wrote: > > > Have you considered putting these things into the ->suspend_late and > > > ->resume_early callbacks, respectively? > > > > > > That might be slightly better as runtime resume is still enabled when > > > the ->suspend and ->resume callbacks run. > > > > There is no ->suspend_late or ->resume_early callbacks in struct > > pcie_port_service_driver so I followed what drivers/pci/pcie/pme.c is > > doing. I guess we could add those callbacks as well if you think they > > are better suited here. > > Maybe these two commits I did 2 years ago but never upstreamed are of help: > > https://github.com/l1k/linux/commit/4f59372f830899e89fea9ba7c090680900d5998e > https://github.com/l1k/linux/commit/ce63b6ed01602e77c56043ee6dfa52ca9d257f88 > > I'm not sure if they still compile & work, sorry. :) Thanks for the pointers. I took a look and then realized that we most probably do not need the custom portdrv specific hooks at all. They are basically doing the same than what PM core is (iterate over children and call service driver PM hook). I don't see any reason why we could not rely on the PM core ops instead of these custom ones but maybe I'm missing something.
