Re: [PATCH v2 0/2] lspci: Add support of JSON output format

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello!

> Because current machine-readable format is very limited and it is
> difficult to extend it to support verbosity options.
> 
> JSON is defacto standard structured format. The key JSON's advantage is
> good portability and extensibility and rich toolchain support. Almost
> every modern utility has JSON format support for output, for example
> lsblk and lscpu.

I agree that a structured output format can be useful at times,
but I do not think that it is so useful that it justifies duplicating
almost the whole source code of lspci. Essentially, you adding a second
copy of all parsing logic with a different output format.

If you find a way how to reduce the code overlap, I could be willing
to accept the change.

				Have a nice fortnight
-- 
Martin `MJ' Mares                          <mj@xxxxxx>   http://mj.ucw.cz/
Faculty of Math and Physics, Charles University, Prague, Czech Rep., Earth
Yes, XSLT is Turing-complete. But so is Intercal.



[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux