On Wed, Mar 14, 2018 at 12:50:28PM +0100, Rafael J. Wysocki wrote:
> On Wed, Mar 14, 2018 at 12:41 PM, Mika Westerberg
> <mika.westerberg@xxxxxxxxxxxxxxx> wrote:
> > Commit eed85ff4c0da ("PCI/DPC: Enable DPC only if AER is available")
> > made DPC control dependent whether AER is enabled in the OS. However, it
> > does not take into account situations where BIOS has not given OS
> > control of AER:
> >
> > acpi PNP0A08:00: _OSC: OS supports [ExtendedConfig ASPM ClockPM Segments MSI]
> > acpi PNP0A08:00: _OSC: platform does not support [AER]
> > acpi PNP0A08:00: _OSC: OS now controls [PCIeHotplug PME PCIeCapability]
> >
> > I think here it is better not to enable DPC even if the capability is
> > available because then it would be against what "Determination of DPC
> > Control" note in PCIe 4.0 sec 6.1.10 recommends.
> >
> > Signed-off-by: Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx>
>
> This may clash with the recent PCIe ports initialization rework from
> Bjorn, please double check.
You are right. I did not notice those changes. I'll rebase this on top
of Bjorn's pci/portdrv branch.
