On Tue, Mar 13, 2018 at 1:12 AM, David Woodhouse <dwmw2@xxxxxxxxxxxxx> wrote: > On Mon, 2018-03-12 at 10:23 -0700, Alexander Duyck wrote: >> >> - .sriov_configure = ena_sriov_configure, >> +#ifdef CONFIG_PCI_IOV >> + .sriov_configure = pci_sriov_configure_simple, >> +#endif >> }; > > I'd like to see that ifdef go away, as discussed. I agree that just > #define pci_sriov_configure_simple NULL > should suffice. As Christoph points out, it's not going to compile if > people try to just invoke it directly. > > I'd also *really* like to see a way to enable this for PFs which don't > have (and don't need) a driver. We seem to have lost that along the > way. Actually the suggestion I had from Don Dutile was that we should be looking at creating a pci-stub like driver specifically for those type of devices, but without the ability to arbitrarily assign devices. Basically we have to white-list it in one device at a time for those kind of things. If you have the device ID of the thing you wanted to have work with pci-stub before I could look at putting together a quick driver and adding it to this set. Thanks. - Alex
