On Sun, Mar 11, 2018 at 04:55:49PM +0100, Lukas Wunner wrote: > On Tue, Mar 06, 2018 at 11:29:40AM +0100, Daniel Vetter wrote: > > On Sat, Mar 03, 2018 at 10:53:24AM +0100, Lukas Wunner wrote: > > > Modernize vga_switcheroo by using a device link to enforce a runtime PM > > > dependency from an HDA controller to the GPU it's integrated into, v2. > > > > > > https://github.com/l1k/linux/commits/switcheroo_devlink_v2 > > > > This all looks really reasonable and like a good cleanup, but it's a bit > > too much detail so I'll punt review to someone else with more clue. > > Patches [3/7] to [7/7] were reviewed by Peter Wu, the HDA bits in > patch [5/7] additionally by Takashi. > > Patch [2/7] was acked by Bjorn. There was no ack for patch [1/7] > (authored by Rafael), but it adressed the objection Bjorn raised > against my original patch, so I'm assuming Bjorn is okay with it. > (Bjorn, please let me know if that isn't the case.) Since it's written by someone else your s-o-b counts as full review (wrt drm-misc rules at least as implemented by dim). So sounds like you have review for all the bits. > The series has been tested on 5 systems, which raises the confidence: > 2x AMD PowerXpress (Mike Lothian, Kai Heng Feng) > 2x Nvidia Optimus (Denis Lisov, Peter Wu) > 1x MacBook Pro > > The issues found during Peter Wu's thorough testing appear to all > be unrelated to this series, as per my e-mail yesterday. > > If there are no objections, I plan to push the series to > drm-misc-next by the middle of the coming week so that it > would still catch the last train to 4.17. Please make sure all maintainers of other bits are ok with that and have given their formal ack for merging through drm-misc. With that you have until end of this week (but don't cut it too short) to sneak it into 4.17. Otherwise just push and it'll land in 4.18. I think you've got all the other pieces. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch
