Re: [PATCH v12 3/6] PCI/PORTDRV: Implement generic find service

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2018-03-06 19:32, Sinan Kaya wrote:
On 2/28/2018 12:04 PM, Oza Pawandeep wrote:
+struct pcie_port_service_driver *pcie_port_find_service(struct pci_dev *dev,
+							u32 service)
+{
+	struct pcie_port_service_driver *drv = NULL;

Remove initialization

+	struct portdrv_service_data pdrvs;
+
+	pdrvs.service = service;

initialize pdrvs.drv = NULL here.

good point, will take care of this. [along with other comments if any]

+	device_for_each_child(&dev->dev, &pdrvs, find_service_iter);
+
+	drv = pdrvs.drv;
+	return drv;
+}



[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux