On Mon, Mar 05, 2018 at 06:22:53PM +0000, Gustavo Pimentel wrote:
> On 02/03/2018 18:03, Lorenzo Pieralisi wrote:
> > [+cc Shawn, Vignesh, Pratyush]
...
> > Is it correct to leave pcie-histb.c as-is ? I do not think it is.
>
> At the time the first series of this patch came out there wasn't such driver and
> I just start working on this topic on December... Nevertheless, you are right it
> should follow the same procedure that others.
>
> diff --git a/drivers/pci/dwc/pcie-histb.c b/drivers/pci/dwc/pcie-histb.c
> index 70b5c0b..5d47b90 100644
> --- a/drivers/pci/dwc/pcie-histb.c
> +++ b/drivers/pci/dwc/pcie-histb.c
> @@ -207,13 +207,6 @@ static struct dw_pcie_host_ops histb_pcie_host_ops = {
> .host_init = histb_pcie_host_init,
> };
>
> -static irqreturn_t histb_pcie_msi_irq_handler(int irq, void *arg)
> -{
> - struct pcie_port *pp = arg;
> -
> - return dw_handle_msi_irq(pp);
> -}
> -
> static void histb_pcie_host_disable(struct histb_pcie *hipcie)
> {
> reset_control_assert(hipcie->soft_reset);
> @@ -393,14 +386,6 @@ static int histb_pcie_probe(struct platform_device *pdev)
> dev_err(dev, "Failed to get MSI IRQ\n");
> return pp->msi_irq;
> }
> -
> - ret = devm_request_irq(dev, pp->msi_irq,
> - histb_pcie_msi_irq_handler,
> - IRQF_SHARED, "histb-pcie-msi", pp);
> - if (ret) {
> - dev_err(dev, "cannot request MSI IRQ\n");
> - return ret;
> - }
> }
>
> hipcie->phy = devm_phy_get(dev, "phy");
I manually applied the changes on top of Lorenzo's pci/dwc-msi branch,
and pcie-histb driver still works fine.
Tested-by: Shawn Guo <shawn.guo@xxxxxxxxxx>
