On 1/16/2018 7:56 PM, Bjorn Helgaas wrote: > I think Sinan is saying that if a DPC Port observes its own unmasked > uncorrectable error (i.e., not something it learned about by receiving > an ERR_* message), it will set a bit in an AER status register. > > Since we do not set DPC ERR_COR Enable, the DPC Port does not generate > an ERR_COR Message, so the AER driver never learns about the error and > never clears the AER status register. So we'll decode the AER status > (with your current patch), but we don't clear it, so if another error > occurs, the AER logging won't work correctly. Yes, this is what I was meaning. I see that Keith took care of this in the new series. -- Sinan Kaya Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.