On Thu, Dec 14, 2017 at 04:14:52PM +0100, Thierry Reding wrote: > On Mon, Oct 30, 2017 at 07:27:13PM +0530, Manikanta Maddireddy wrote: > > In Tegra186 PHY programming is done by BPMP-FW, so PHY calls are skipped > > in driver. REFCLK pad settings are independent of PHY and should be > > programmed by driver. So move REFCLK pad settings out of phy_power_on(). > > These pad settings improve REFCLK peak to peak amplitude. > > > > Signed-off-by: Manikanta Maddireddy <mmaddireddy@xxxxxxxxxx> > > --- > > V3: > > * Corrected commit log > > V2: > > * no change in this patch > > > > drivers/pci/host/pci-tegra.c | 20 +++++++++++++------- > > 1 file changed, 13 insertions(+), 7 deletions(-) > > As far as I can tell, this is a bugfix that can and should be applied > independently of the rest of the series. > > Acked-by: Thierry Reding <treding@xxxxxxxxxx> Ok, I will apply - I would add a Fixes: tag though. Is: Fixes: cf5d31801278 ("PCI: tegra: Program PADS_REFCLK_CFG* always, not just on legacy SoCs") the correct commit ? Thanks, Lorenzo