On Fri, Dec 08, 2017 at 02:07:54PM +0530, Manikanta Maddireddy wrote: > > > On 06-Dec-17 1:34 AM, Bjorn Helgaas wrote: > > On Fri, Dec 01, 2017 at 02:50:02PM +0530, Manikanta Maddireddy wrote: > >> PCI subsystem pass pci_bus pointer to pci_ops callback functions, Tegra > > > > s/PCI subsystem pass/The PCI subsystem passes a/ > > s/, Tegra/. The Tegra/ > > > >> host driver use pci_find_host_bridge() to get pci_host_bridge from pci_bus. > > > > s/use/uses/ > > > >> Export pci_find_host_bridge() to allow Tegra PCIe driver to be compiled as > >> loadable kernel module. > > > > s/allow Tegra/allow the Tegra/ > > s/loadable/a loadable/ > > > > But why do you need pci_find_host_bridge() at all? Most drivers use > > the pci_bus.sysdata pointer for this purpose, e.g., see db271747a04d > > ("PCI: mediatek: Use bus->sysdata to get host private data") > > I will send a patch to use bus->sysdata instead of pci_find_host_bridge(). That would be excellent! Thank you! Bjorn