On Fri, Dec 01, 2017 at 02:50:02PM +0530, Manikanta Maddireddy wrote:
> PCI subsystem pass pci_bus pointer to pci_ops callback functions, Tegra
s/PCI subsystem pass/The PCI subsystem passes a/
s/, Tegra/. The Tegra/
> host driver use pci_find_host_bridge() to get pci_host_bridge from pci_bus.
s/use/uses/
> Export pci_find_host_bridge() to allow Tegra PCIe driver to be compiled as
> loadable kernel module.
s/allow Tegra/allow the Tegra/
s/loadable/a loadable/
But why do you need pci_find_host_bridge() at all? Most drivers use
the pci_bus.sysdata pointer for this purpose, e.g., see db271747a04d
("PCI: mediatek: Use bus->sysdata to get host private data")
> Signed-off-by: Manikanta Maddireddy <mmaddireddy@xxxxxxxxxx>
> ---
> V2:
> * commit message update
> V3:
> * EXPORT_SYMBOL is changed to EXPORT_SYMBOL_GPL
>
> drivers/pci/host-bridge.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/pci/host-bridge.c b/drivers/pci/host-bridge.c
> index add66236215c..b8c0fcde9bd7 100644
> --- a/drivers/pci/host-bridge.c
> +++ b/drivers/pci/host-bridge.c
> @@ -22,6 +22,7 @@ struct pci_host_bridge *pci_find_host_bridge(struct pci_bus *bus)
>
> return to_pci_host_bridge(root_bus->bridge);
> }
> +EXPORT_SYMBOL_GPL(pci_find_host_bridge);
>
> struct device *pci_get_host_bridge_device(struct pci_dev *dev)
> {
> --
> 2.1.4
>
