On Wed, 22 Nov 2017, Timur Tabi <timur@xxxxxxxxxxxxxx> wrote: > On 11/22/2017 01:50 PM, Jani Nikula wrote: >>>> dev_priv->bridge_dev = pci_get_domain_bus_and_slot(0, 0, >>>> PCI_DEVFN(0, 0)); >>>> >>>> Can you please resend like that. >>> I did this at the beginning and but, I hit a checkpatch problem with >>> more than 80 characters. That's why, I moved the devfn value assignment >>> to a different line. >> Please ignore checkpatch when it makes the code worse. 80 is not a >> strict limit. > > How about this: > > dev_priv->bridge_dev = > pci_get_domain_bus_and_slot(0, 0, PCI_DEVFN(0, 0)); > > That should fit, and it's very readable. *shrug* I'm fine with either, though I think the first one I like more when I git grep stuff. Get more contex. But let's not get hung up on this. BR, Jani. -- Jani Nikula, Intel Open Source Technology Center
