On Sat, Oct 28, 2017 at 02:01:46PM -0400, Sinan Kaya wrote: > I was looking for some code that can be used between OF and ACPI rather than > duplicating the code in two different places just to extract some information > from the platform firmware. > > My initial look at your code suggested it to be very generic except the IRQ > read function. > > I was expecting that the kernel's PCI Wake handling to be common whether the IRQ > information is coming from DT/ACPI. I'm not an ACPI expert, but from reading the existing ACPI code handling this wakeup configuration...they're not really that similar. Whereas for device tree firmware there's not much magic to it -- the OS is really just configuring a standard interrupt with wakeup capability -- ACPI layers this all behind its GPE (General Purpose Event) abstraction, which doesn't act like a typical interrupt. You manage GPE handlers with a completely different set of APIs. Anyway, Rafael seemed to have some of his own opinions (didn't like the current approach it seems), so maybe we're all completely off track here. Regards, Brian
