On 10/26/2017 9:28 AM, Jeffy Chen wrote: > drivers/pci/Makefile | 2 +- > drivers/pci/pci-of.c | 136 +++++++++++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 137 insertions(+), 1 deletion(-) > create mode 100644 drivers/pci/pci-of.c > > diff --git a/drivers/pci/Makefile b/drivers/pci/Makefile > index 66a21acad952..4f76dbdb024c 100644 > --- a/drivers/pci/Makefile > +++ b/drivers/pci/Makefile > @@ -49,7 +49,7 @@ obj-$(CONFIG_PCI_ECAM) += ecam.o > > obj-$(CONFIG_XEN_PCIDEV_FRONTEND) += xen-pcifront.o > > -obj-$(CONFIG_OF) += of.o > +obj-$(CONFIG_OF) += of.o pci-of.o If the intention is to push this to pci directory, this code needs to be made platform agnostic by splitting into two pieces. I think you can make this code common by abstracting the IRQ number and have some generic code like pci-wake.c in pci directory without the of prefix in this file. Then, you can have some other OF specific code in the drivers/of directory that reads the IRQ from OF and calls the common code in PCI directory. -- Sinan Kaya Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.
