On Thu, Oct 12, 2017 at 7:45 AM, Steve Lin <steven.lin1@xxxxxxxxxxxx> wrote: > Hi Roopa, > > The attributes added in this patchset are not really the same type as > ethtool - these are more device configuration type attributes. The > speeds you saw, for example, affect the pre-OS [i.e. PXE boot time] > configuration for a port, and aren't run-time speed changes on a given > netdev like ethtool configures. As Jiri mentioned, I will add some > comments to better describe each of the attributes. > > So I don't think there's much duplication here with ethtool. > > That said, there also shouldn't be anything in the patchset that would > preclude some future migration of ethtool settings to using devlink or > rtnetlink API. > ok, ack, thanks for the clarification. Just trying to find a best netlink place for future ethtool migration to netlink.
