Hi Roopa, The attributes added in this patchset are not really the same type as ethtool - these are more device configuration type attributes. The speeds you saw, for example, affect the pre-OS [i.e. PXE boot time] configuration for a port, and aren't run-time speed changes on a given netdev like ethtool configures. As Jiri mentioned, I will add some comments to better describe each of the attributes. So I don't think there's much duplication here with ethtool. That said, there also shouldn't be anything in the patchset that would preclude some future migration of ethtool settings to using devlink or rtnetlink API. Steve On Thu, Oct 12, 2017 at 10:35 AM, Roopa Prabhu <roopa@xxxxxxxxxxxxxxxxxxx> wrote: > On Thu, Oct 12, 2017 at 6:34 AM, Steve Lin <steven.lin1@xxxxxxxxxxxx> wrote: >> Adds a devlink command for getting & setting device configuration >> parameters, and enumerates a bunch of those parameters as devlink >> attributes. Also introduces an attribute that can be set by a >> driver to indicate that the config change doesn't take effect >> until the next restart (as in the case of the bnxt driver changes >> in this patchset, for which all the configuration changes affect NVM >> only, and aren't loaded until the next restart.) >> >> bnxt driver patches make use of these new devlink cmds/attributes. >> >> Steve Lin (3): >> devlink: Add config parameter get/set operations >> bnxt: Move generic devlink code to new file >> bnxt: Add devlink support for config get/set >> > > Is the goal here to move all ethtool operations to devlink (I saw some > attrs related to speed etc). ?. > We do need to move ethtool attrs to netlink and devlink is a good > place (and of-course leave the current ethtool api around for backward > compatibility).
