On Fri, Sep 08, 2017 at 01:26:21PM +0200, Mason wrote: > On 05/09/2017 20:27, Bjorn Helgaas wrote: > > >Use tabs (not spaces) for indentation. No functional change intended. > > git diff -b should be empty, right? Empty except for a line join. > >@@ -280,12 +280,12 @@ static int xgene_v2_pcie_ecam_init(struct pci_config_window *cfg) > > } > > struct pci_ecam_ops xgene_v2_pcie_ecam_ops = { > >- .bus_shift = 16, > >- .init = xgene_v2_pcie_ecam_init, > >- .pci_ops = { > >- .map_bus = xgene_pcie_map_bus, > >- .read = xgene_pcie_config_read32, > >- .write = pci_generic_config_write, > >+ .bus_shift = 16, > >+ .init = xgene_v2_pcie_ecam_init, > >+ .pci_ops = { > >+ .map_bus = xgene_pcie_map_bus, > >+ .read = xgene_pcie_config_read32, > >+ .writei = pci_generic_config_write, > > } > > }; > > #endif > > Spurious 'i' in '.writei' ;-) Indeed, "git diff -b" would have saved me a trip through the auto-builder. But this is fixed.