Hi Bjorn, Thanks a lot for your comments! > -----Original Message----- > From: Bjorn Helgaas [mailto:helgaas@xxxxxxxxxx] > Sent: 2017年8月25日 12:23 > To: Z.q. Hou <zhiqiang.hou@xxxxxxx> > Cc: linux-pci@xxxxxxxxxxxxxxx; bhelgaas@xxxxxxxxxx; > jingoohan1@xxxxxxxxx; Joao.Pinto@xxxxxxxxxxxx; M.h. Lian > <minghuan.lian@xxxxxxx>; Mingkai Hu <mingkai.hu@xxxxxxx>; Roy Zang > <roy.zang@xxxxxxx>; svarbanov@xxxxxxxxxx; niklas.cassel@xxxxxxxx; > jesper.nilsson@xxxxxxxx > Subject: Re: [PATCHv4 4/9] PCI: layerscape: refactor the host_init function > > On Fri, Aug 25, 2017 at 03:16:36AM +0000, Z.q. Hou wrote: > > Hi Bjorn, > > > > Thanks a lot for your comments! > > > > > -----Original Message----- > > > From: Bjorn Helgaas [mailto:helgaas@xxxxxxxxxx] > > > Sent: 2017年8月25日 1:12 > > > To: Z.q. Hou <zhiqiang.hou@xxxxxxx> > > > Cc: linux-pci@xxxxxxxxxxxxxxx; bhelgaas@xxxxxxxxxx; > > > jingoohan1@xxxxxxxxx; Joao.Pinto@xxxxxxxxxxxx; M.h. Lian > > > <minghuan.lian@xxxxxxx>; Mingkai Hu <mingkai.hu@xxxxxxx>; Roy Zang > > > <roy.zang@xxxxxxx>; svarbanov@xxxxxxxxxx; niklas.cassel@xxxxxxxx; > > > jesper.nilsson@xxxxxxxx > > > Subject: Re: [PATCHv4 4/9] PCI: layerscape: refactor the host_init > > > function > > > > > > On Wed, Aug 23, 2017 at 02:08:51PM +0800, Zhiqiang Hou wrote: > > > > From: Hou Zhiqiang <Zhiqiang.Hou@xxxxxxx> > > > > > > > > Make the ls1021a's host_init reuse layerscape platform's common > > > > host_init function. > > > > > > This patch does two things: > > > > > > 1) Moves ls1021_pcie_host_init() to a different place in the file > > > 2) Calls ls_pcie_host_init() instead of repeating that code in > > > ls1021_pcie_host_init() > > > > > > Those should be separate patches so they're easier to review. > > > > > > Or if you don't really need to move ls1021_pcie_host_init() to a > > > different place, that would be even easier. > > > > Moved ls1021_pcie_host_init() to this place behand the func > ls_pcie_host_init is to call ls_pcie_host_init without adding a declaration of it. > Is it necessary to separate it? > > Yes, please. I want to see one patch that *only* moves the function (and > mentions why you're moving it) and another that *only* calls > ls_pcie_host_init() instead of repeating that code in ls1021_pcie_host_init(). > That way, both patches are trivial to review. The combined one is not trivial > to review. Got it, will separate it in next version. Thanks, Zhiqiang
