On Sat, 24 Jun 2017 02:34:06 PDT (-0700), geert@xxxxxxxxxxxxxx wrote: > Hi Palmer, > > On Sat, Jun 24, 2017 at 3:50 AM, Palmer Dabbelt <palmer@xxxxxxxxxxx> wrote: >> Multiple architectures define this as an empty function, and I'm adding >> another one as part of the RISC-V port. This adds a __weak version of >> pci_fixup_bios and deletes the now obselete ones in a handful of ports. >> >> The only functional change should be that microblaze used to export >> pcibios_fixup_bus. None of the other architectures export this, so I >> just dropped it. >> >> Signed-off-by: Palmer Dabbelt <palmer@xxxxxxxxxxx> > > Given this is an empty function, wouldn't it make more sense to have > a static inline in asm-generic, protected by #ifndef pcibios_fixup_bus? I think the PCI people were considering changing this from a per-arch function to a per-controller function, so I think the inline won't help any there. I think since they hope to eventually clean up all the __weak functions it fits a bit better this way, but I'm really fine with anything here.
