Hi Palmer, On Sat, Jun 24, 2017 at 3:50 AM, Palmer Dabbelt <palmer@xxxxxxxxxxx> wrote: > Multiple architectures define this as an empty function, and I'm adding > another one as part of the RISC-V port. This adds a __weak version of > pci_fixup_bios and deletes the now obselete ones in a handful of ports. > > The only functional change should be that microblaze used to export > pcibios_fixup_bus. None of the other architectures export this, so I > just dropped it. > > Signed-off-by: Palmer Dabbelt <palmer@xxxxxxxxxxx> Given this is an empty function, wouldn't it make more sense to have a static inline in asm-generic, protected by #ifndef pcibios_fixup_bus? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds