Hi Christoph > -----Original Message----- > From: linux-pci-owner@xxxxxxxxxxxxxxx [mailto:linux-pci- > owner@xxxxxxxxxxxxxxx] On Behalf Of Christoph Hellwig > Sent: 22 May 2017 18:44 > To: Gabriele Paoloni > Cc: Christoph Hellwig; bhelgaas@xxxxxxxxxx; helgaas@xxxxxxxxxx; > Linuxarm; linux-pci@xxxxxxxxxxxxxxx; lukas@xxxxxxxxx; linux- > kernel@xxxxxxxxxxxxxxx; mika.westerberg@xxxxxxxxxxxxxxx; liudongdong > (C) > Subject: Re: [PATCH v3 1/2] PCI/portdrv: add support for different MSI > interrupts for PCIe port services > > On Sun, May 21, 2017 at 03:00:46PM +0000, Gabriele Paoloni wrote: > > > > I thought that in your previous review you meant to say that we > should > > avoid 2 instances of the same comment (in this patchset I only have > this > > instance as I have removed the same comment from patch 2/2...) > > No, there is no pointin the comment. The whole point of pci_irq_vector > is to abstract away from how to get at the interrupt in detail. There > is no need to comment on this at the callsite. If you think the > existing documentation for the function is not good enough send a patch > to improve it there instead of commenting the callsites. Ok got it. I have just sent out v5 where this is fixed. Thanks Gab
