Hi Christoph > -----Original Message----- > From: linux-pci-owner@xxxxxxxxxxxxxxx [mailto:linux-pci- > owner@xxxxxxxxxxxxxxx] On Behalf Of Christoph Hellwig > Sent: 21 May 2017 09:33 > To: Gabriele Paoloni > Cc: bhelgaas@xxxxxxxxxx; helgaas@xxxxxxxxxx; Linuxarm; linux- > pci@xxxxxxxxxxxxxxx; lukas@xxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; > mika.westerberg@xxxxxxxxxxxxxxx; hch@xxxxxxxxxxxxx; liudongdong (C) > Subject: Re: [PATCH v3 1/2] PCI/portdrv: add support for different MSI > interrupts for PCIe port services > > > + * > > + * pci_irq_vector() below is able to handle entry > diff erently > > + * depending on MSI vs MSI-x case > > + * > > */ > > One more instance of this comment left :) I thought that in your previous review you meant to say that we should avoid 2 instances of the same comment (in this patchset I only have this instance as I have removed the same comment from patch 2/2...) > > > pcie_capability_read_word(dev, PCI_EXP_FLAGS, ®16); > > entry = (reg16 & PCI_EXP_FLAGS_IRQ) >> 9; > > @@ -100,7 +107,10 @@ static int pcie_port_enable_msix(struct pci_dev > *dev, int *irqs, int mask) > > * MSI/MSI-X vectors assigned to the port is going to be > used > > * for AER, where "For MSI-X, the value in this register > > * indicates which MSI-X Table entry is used to generate > the > > - * interrupt message." > > + * interrupt message." and "For MSI, the value > > + * in this field indicates the offset between the base > Message > > + * Data and the interrupt message that is generated." > > + * > > */ > > And while this is getting a little too deep into nitpicking: we > usually > don't add empty lines to the end of comments. Ok I can remove the extra line and send out patch v4... Many thanks Gab
