Hi Christoph > -----Original Message----- > From: linux-pci-owner@xxxxxxxxxxxxxxx [mailto:linux-pci- > owner@xxxxxxxxxxxxxxx] On Behalf Of Christoph Hellwig > Sent: 18 May 2017 10:27 > To: Gabriele Paoloni > Cc: bhelgaas@xxxxxxxxxx; helgaas@xxxxxxxxxx; Linuxarm; linux- > pci@xxxxxxxxxxxxxxx; lukas@xxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; > mika.westerberg@xxxxxxxxxxxxxxx; hch@xxxxxxxxxxxxx; liudongdong (C) > Subject: Re: [PATCH v2 1/2] PCI/portdrv: add support for different MSI > interrupts for PCIe port services > > > - * pcie_port_enable_msix - try to set up MSI-X as interrupt mode for > given port > > + * pcie_port_enable_msix_or_msi - try to set up MSI-X or MSI as > interrupt mode > > + * for given port > > just rename it to pcie_port_enable_vecs to avoid the overly long line.. The function is actually renamed but I missed to update the comment, my bad. > > > + * pci_irq_vector() below is able to handle entry > differently > > + * depending on MSI vs MSI-x case > > As mentioned in the review for the other patch: no need to repeat > this for every user of pci_irq_vector. I also missed to remove this comment > > Otherwise this looks fine to me: > > Reviewed-by: Christoph Hellwig <hch@xxxxxx> Many thanks I'll fix comments and send out v3 straight Cheers Gab
