> - * pcie_port_enable_msix - try to set up MSI-X as interrupt mode for given port > + * pcie_port_enable_msix_or_msi - try to set up MSI-X or MSI as interrupt mode > + * for given port just rename it to pcie_port_enable_vecs to avoid the overly long line.. > + * pci_irq_vector() below is able to handle entry differently > + * depending on MSI vs MSI-x case As mentioned in the review for the other patch: no need to repeat this for every user of pci_irq_vector. Otherwise this looks fine to me: Reviewed-by: Christoph Hellwig <hch@xxxxxx>