Hi,
On 3/28/2017 7:45 PM, Shameerali Kolothum Thodi wrote:
-----Original Message-----
From: Sricharan R [mailto:sricharan@xxxxxxxxxxxxxx]
Sent: Tuesday, March 28, 2017 5:54 AM
To: Robin Murphy; Shameerali Kolothum Thodi; Wangzhou (B);
will.deacon@xxxxxxx; joro@xxxxxxxxxx; lorenzo.pieralisi@xxxxxxx;
iommu@xxxxxxxxxxxxxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx;
linux-arm-msm@xxxxxxxxxxxxxxx; m.szyprowski@xxxxxxxxxxx;
bhelgaas@xxxxxxxxxx; linux-pci@xxxxxxxxxxxxxxx; linux-
acpi@xxxxxxxxxxxxxxx; tn@xxxxxxxxxxxx; hanjun.guo@xxxxxxxxxx;
okaya@xxxxxxxxxxxxxx
Subject: Re: [PATCH V9 00/11] IOMMU probe deferral support
Hi,
[...]
From the logs its clear that when ixgbevf driver originally probes
and adds the device to smmu the dma mask is 32, but when it binds
to vfio-pci, it becomes 64 bit.
Just to add to that, the mask is set to 64 bit in the ixgebvf driver
probe[1]
Aha, but of course it's still the same struct device getting bound to
VFIO later, so whatever mask the first driver set is still in there
when we go through of_dma_configure() the second time (and the fact
that we go through more than once being the new behaviour). So yes,
this is a legitimate problem and we really do need to be robust
against size overflow. I reckon the below tweak of your fix is
probably the way to go; cleaning up the arch_setup_dma_ops() interface
can happen later.
ok, i will add this fix separately and also the acpi fix that lorenzo has
suggested in patch #8 in to the series after testing confirmation.
I can confirm that the patches fixes the issues reported here . Both
DT and ACPI works now.
Thanks for the testing. Will repost with the fixes.
Regards,
Sricharan
--
"QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a
member of Code Aurora Forum, hosted by The Linux Foundation
