> -----Original Message----- > From: Lorenzo Pieralisi [mailto:lorenzo.pieralisi@xxxxxxx] > Sent: Friday, March 24, 2017 2:44 PM > To: Shameerali Kolothum Thodi > Cc: Sricharan R; Wangzhou (B); robin.murphy@xxxxxxx; > will.deacon@xxxxxxx; joro@xxxxxxxxxx; iommu@xxxxxxxxxxxxxxxxxxxxxxxxxx; > linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-arm-msm@xxxxxxxxxxxxxxx; > m.szyprowski@xxxxxxxxxxx; bhelgaas@xxxxxxxxxx; linux- > pci@xxxxxxxxxxxxxxx; linux-acpi@xxxxxxxxxxxxxxx; tn@xxxxxxxxxxxx; > hanjun.guo@xxxxxxxxxx; okaya@xxxxxxxxxxxxxx > Subject: Re: [PATCH V9 00/11] IOMMU probe deferral support > > On Fri, Mar 24, 2017 at 09:27:51AM +0000, Shameerali Kolothum Thodi wrote: > > [...] > > > @@ -107,7 +107,7 @@ int of_dma_configure(struct device *dev, struct > device_node *np) > > ret = of_dma_get_range(np, &dma_addr, &paddr, &size); > > if (ret < 0) { > > dma_addr = offset = 0; > > - size = dev->coherent_dma_mask + 1; > > + size = max(dev->coherent_dma_mask, dev- > >coherent_dma_mask + 1); > > > > @@ -1386,7 +1387,8 @@ int acpi_dma_configure(struct device *dev, enum > dev_dma_attr attr) > > * Assume dma valid range starts at 0 and covers the whole > > * coherent_dma_mask. > > */ > > - arch_setup_dma_ops(dev, 0, dev->coherent_dma_mask + 1, > iommu, > > + size = max(dev->coherent_dma_mask, dev->coherent_dma_mask + > 1); > > size is not defined in acpi_dma_configure(), so there is something missing in > the diff above, just to make sure we are testing the same thing. > > Mind posting kernel logs with and without patch above (fixed) for DT boot > and ACPI boot please. Sure. We will rerun the tests to create the logs again and share. Also need to double check, v9 patches are applied correctly on top of our branch. If I remember correctly v7 was fine with DT(didn't test with ACPI). But then as Shicharan said it had that size fix. Thanks, Shameer [...]
