Hi Bjorn, On 3/15/2017 10:33 AM, Sinan Kaya wrote: > On 3/14/2017 3:21 PM, Bjorn Helgaas wrote: >> On Mon, Mar 13, 2017 at 07:21:42PM -0400, Sinan Kaya wrote: >>> On 3/13/2017 7:08 PM, Bjorn Helgaas wrote: >>>> On Mon, Mar 13, 2017 at 06:05:55PM -0400, Sinan Kaya wrote: >>>>> On 3/13/2017 5:46 PM, Bjorn Helgaas wrote: >>>>>> What is this series based on? Unless they depend on other in-flight >>>>>> patches, I apply patches to branches based on my "master" branch, >>>>>> which is typically -rc1 or -rc2 (it's currently v4.11-rc1). These >>>>>> don't apply to either. >>>>> >>>>> It looks like I am on 4.10. I can rebase and post again. >>>> >>>> Rebasing would be good, but I can give you some comments on your v4, >>>> now that I can apply it and see what it looks like. >>>> >>> >>> Thanks, >>> >>> I'm mostly done with the rebase. I'll have to retest tomorrow morning and >>> then post. >>> >>> I had to drop this >>> >>> - for endpoints, have pcie_aspm_init_link_state() do the actual ASPM >>> setup of the link as it currently does. >>> >>> during rebase. >>> >>> The reason is that the clock configuration needs to switch to common clock >>> mode across all the devices before any ASPM latency is read/configured. >>> >>> Common clock configuration seem to be trying to walk the device list. >>> >>> Here is the untested version. It might not even compile. >>> I'll wait until I receive your comments. >> >> I had already started looking at v4, so these comments are based on >> that. Your v4 is a great start and these are all general comments so >> I didn't try to match each one up with the code. >> >> - Goal: retain BIOS ASPM config of bridge even if children are >> removed and re-added. Is there a bugzilla for this problem? > Is there a common place to add code after the bus scan similar to pci_init_capabilities(). I really don't like the ASPM call in the middle of scan function. Sinan -- Sinan Kaya Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.
