Hi Geert [...] > > { > > - .compatible = "hisilicon,pcie-almost-ecam", > > + .compatible = "hisilicon,pcie-almost-ecam-hip06", > > Shouldn't that be "hisilicon,hip06-pcie-almost-ecam"? > > > + .data = (void *) &hisi_pcie_platform_ops, > > + }, > > + { > > + .compatible = "hisilicon,pcie-almost-ecam-hip07", > > Shouldn't that be "hisilicon,hip07-pcie-almost-ecam"? Indeed prefixing the SoC name is more consistent and it looks better Many thanks Gab > > > .data = (void *) &hisi_pcie_platform_ops, > > }, > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux- > m68k.org > > In personal conversations with technical people, I call myself a > hacker. But > when I'm talking to journalists I just say "programmer" or something > like that. > -- Linus Torvalds