On Mon, Feb 06, 2017 at 09:32:02AM -0800, Christoph Hellwig wrote:
> On Fri, Feb 03, 2017 at 09:53:30PM +0100, Greg Kroah-Hartman wrote:
> > > +/* pci_dev priv_flags */
> > > +#define PCI_DEV_DISCONNECTED 0
> > > +
> > > +static inline int pci_dev_set_disconnected(struct pci_dev *dev, void *unused)
> > > +{
> > > + set_bit(PCI_DEV_DISCONNECTED, &dev->priv_flags);
> >
> > Why a single bit? Are you trying to do this without locking or
> > something? And if you want a bit, what's wrong with a C bit type? Or
> > just a boolean?
>
> What's a C bit type?
Sorry, was thinking of:
unsigned foo:2;
don't know what the "real" name for that is...
thanks,
greg k-h
