On Fri, Feb 03, 2017 at 09:53:30PM +0100, Greg Kroah-Hartman wrote:
> > +/* pci_dev priv_flags */
> > +#define PCI_DEV_DISCONNECTED 0
> > +
> > +static inline int pci_dev_set_disconnected(struct pci_dev *dev, void *unused)
> > +{
> > + set_bit(PCI_DEV_DISCONNECTED, &dev->priv_flags);
>
> Why a single bit? Are you trying to do this without locking or
> something? And if you want a bit, what's wrong with a C bit type? Or
> just a boolean?
What's a C bit type? set_bit and friends defintively are the standard
for being able to set individual bits without worrying for RMW races.
So while a bool would work fine here for now, this seems much easier
to extent for any flag in the future if we need one.
