Re: PCI: Revert "PCI: Add runtime PM support for PCIe ports"

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> On Mon, Jan 09, 2017 at 07:17:17PM -0500, David Airlie wrote:
> > just FYI, but W541 with Fedora 25 and Linux 4.10-rc3 + drm-next and the efi
> > fix (you might want to motivate that fix a bit harder), seems to be working
> > well.
> 
> The efi fix is on the efi.git next branch without stable designation,
> i.e. slated for 4.11 not 4.10, and Matt Fleming usually sends his pull
> to Ingo between rc4 and rc5.
> 
> 
> > I can suspend/resume, and the nvidia seems to go off.
> > 
> > [  411.799035] nouveau 0000:01:00.0: DRM: suspending console...
> > [  411.799059] nouveau 0000:01:00.0: DRM: suspending display...
> > [  411.799119] nouveau 0000:01:00.0: DRM: evicting buffers...
> > [  411.799125] nouveau 0000:01:00.0: DRM: waiting for kernel channels to go
> > idle...
> > [  411.799176] nouveau 0000:01:00.0: DRM: suspending client object trees...
> > [  411.805616] nouveau 0000:01:00.0: DRM: suspending kernel object tree...
> > [  413.217090] device_pm-0235 device_set_power      : Device [VID1]
> > transitioned to D3hot
> > [  413.217099] device_pm-0124 device_get_power      : Device [VID1] power
> > state is (unknown)
> > [  413.230201] thinkpad_acpi: EC reports that Thermal Table has changed
> > [  413.351497]     power-0275 __acpi_power_off      : Power resource [NVP3]
> > turned off
> > [  413.351507] device_pm-0235 device_set_power      : Device [PEG]
> > transitioned to D3hot
> > [  413.351526]     power-0189 power_get_state       : Resource [NVP3] is
> > off
> > [  413.351530]     power-0219 power_get_list_state  : Resource list is off
> > [  413.351542]     power-0189 power_get_state       : Resource [NVP2] is on
> > [  413.351545]     power-0219 power_get_list_state  : Resource list is on
> > [  413.351548] device_pm-0124 device_get_power      : Device [PEG] power
> > state is D2
> > 
> > That is with some acpi debugging enabled (though I'm not quite sure why D2
> > is where it ends up).
> 
> The ACPI D2 state seems fishy indeed, could you post the log for a
> runtime resume as well?  It would be interesting to see how it gets
> out of this incorrect power state.  Also, what is the firmware version
> that you're using?  If it's not GNET80WW (2.28), could you attach an
> acpidump to the bugzilla entry?
> 
> https://bugzilla.kernel.org/show_bug.cgi?id=190861
> 

Okay I found a possible race and sent patches to fix it dri-devel

https://patchwork.freedesktop.org/series/17731/

also https://cgit.freedesktop.org/~airlied/linux/log/?h=drm-next-wip-fix-runtime-race
here with the efi patch also.

It might just be that enabling runtime PM makes things actually suspend/resume and
we can hit this, or else I've just found something else in the area.

Dave.

--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux