On 11/15/2016 06:10 PM, Srinivas Kandagatla wrote: > > > On 15/11/16 15:08, Stanimir Varbanov wrote: >>>> I don't like MSM8996_ prefix. Could you invent a macro which depending >>>> >> on controller selects proper offset? >>> > >>> > maybe some like this ?? >>> > >>> > #define PCIE20_PARF_AXI_MSTR_WR_ADDR_HALT_V2 0x1A8 >> No, I wanted to preserve the name of the register offset. By that way in >> the next pcie controller version we do not need to have >> PCIE20_PARF_AXI_MSTR_WR_ADDR_HALT_V3. >> >> I was thinking for something like >> >> PCIE20_PARF_AXI_MSTR_WR_ADDR_HALT(ver) \ >> ((ver) == VERSION_1 ? 0x178 : 0x1A8) >> >> But you will need to extend qcom_pcie_ops with new member to store the >> version. >> >> It's up to you ... or we can fix it when new version of the controller >> appear. > TBH, I don't want to add this just for this one case, looks bit over do. > So I skipped to using V2 Suffix. > We can fix later if required. OK, sounds good. regards, Stan -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
