Re: [PATCH v2 0/6] PCI: altera: Cleanups

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Oct 12, 2016 at 07:46:59AM -0500, Bjorn Helgaas wrote:
>   - Add local "dev" pointers to reduce repetition of things like
>     "&pdev->dev".
> 
>   - Remove platform drvdata because it appears unused (we called
>     platform_set_drvdata() but not platform_get_drvdata()).
> 
>   - Removed an unnecessary platform_get_resource() return value check.
> 
>   - Rework TLB_CFG_DW0 and TLP_CFG_DW1 to make the code prettier.
> 
> Nothing here should change the behavior of the driver.
> 
> Changes from v1:
>   I dropped the following patches because they were a lot of churn for
>   questionable benefit:
>     PCI: altera: Name private struct pointer "altera" consistently
>     PCI: altera: Rename _altera_pcie_cfg_read() to altera_raw_cfg_read()
>     PCI: altera: Rename CRA accessors
>     PCI: altera: Swap order of altera_cra_writel() reg/val arguments
> 
> ---
> 
> Bjorn Helgaas (6):
>       PCI: altera: Add local struct device pointers
>       PCI: altera: Remove unused platform data
>       PCI: altera: Remove redundant platform_get_resource() return value check
>       PCI: altera: Rename altera_pcie_valid_config() to altera_pcie_valid_device()
>       PCI: altera: Simplify TLB_CFG_DW0 usage
>       PCI: altera: Simplify TLP_CFG_DW1 usage

I applied these to pci/host-altera for v4.9.  I hope to ask Linus to
pull them tomorrow, so if you see any issues, let me know soon.
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux