Hi Arnd 在 2016/9/1 22:02, Arnd Bergmann 写道:
2. We need to backward compatible with the old dt way config access as below code, so we have to call hisi_pcie_common_cfg_read() when accessing the RC config space. For this, we have to call hisi_pcie_common_cfg_read(). drivers/pci/host/pcie-hisi.c static inline int hisi_pcie_cfg_read(struct pcie_port *pp, int where, int size, u32 *val) { struct hisi_pcie *pcie = to_hisi_pcie(pp); return hisi_pcie_common_cfg_read(pcie->reg_base, where, size, val); } static struct pcie_host_ops hisi_pcie_host_ops = { .rd_own_conf = hisi_pcie_cfg_read, .wr_own_conf = hisi_pcie_cfg_write, .link_up = hisi_pcie_link_up, };I think this would be easier if you separate the ACPI code from the DT code and not try to have a common file used for both. Sharing the config space accessors really isn't worth it when both variants are fairly simple to do, but they don't fit in a common model because one is called from the ACPI quirks and the other is called from the dw-pcie driver with completely different calling conventions.
I agree, many thanks. Thanks Dongdong
ARnd -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html .
-- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
