Hi Rafael, On Tue, Apr 26, 2016 at 11:04:55PM +0200, Rafael J. Wysocki wrote: > On Mon, Apr 25, 2016 at 11:53 AM, Mika Westerberg > <mika.westerberg@xxxxxxxxxxxxxxx> wrote: [snip] > > --- a/drivers/pci/pci-driver.c > > +++ b/drivers/pci/pci-driver.c > > @@ -777,7 +777,12 @@ static int pci_pm_suspend_noirq(struct device *dev) > > > > if (!pci_dev->state_saved) { > > pci_save_state(pci_dev); > > - if (!pci_has_subordinate(pci_dev)) > > + /* > > + * Check if given device can go to low power state. Currently > > + * we allow normal PCI devices and PCI bridges if their > > + * bridge_d3 is set. > > + */ > > + if (!pci_has_subordinate(pci_dev) || pci_dev->bridge_d3) > > I'd add a helper for this, say pci_power_manageable() or similar. He had a helper for this in a prior version and removed it on my suggestion. Sorry Mika, guess I caused you additional work there. :-/ Best regards, Lukas -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html