Hi Mika, I've rebased my Thunderbolt runtime pm patches on v4 of your patches and everything seems to still work fine. d3cold_allowed also works as it should now. As said I've amended my series to allow runtime pm on hotplug ports if they're Thunderbolt ports on a Mac: https://github.com/l1k/linux/commit/a6810db929485c7fc8677f265b1c68e31879ce61 I've also reviewed the patches one more time and spotted only this small nit: On Mon, Apr 25, 2016 at 12:53:24PM +0300, Mika Westerberg wrote: > +static int pcie_port_runtime_resume(struct device *dev) > +{ > + pm_runtime_mark_last_busy(dev); > + return 0; > +} The PM core seems to do this automatically, see rpm_resume(): https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/drivers/base/power/runtime.c#n749 So you could just drop the .runtime_resume entry here and it shouldn't result in any functional change: > @@ -101,6 +122,9 @@ static const struct dev_pm_ops pcie_portdrv_pm_ops = { > .poweroff = pcie_port_device_suspend, > .restore = pcie_port_device_resume, > .resume_noirq = pcie_port_resume_noirq, > + .runtime_suspend = pcie_port_runtime_suspend, > + .runtime_resume = pcie_port_runtime_resume, > + .runtime_idle = pcie_port_runtime_idle, Best regards, Lukas -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
