Re: Problems since commit Recognize that Interrupt Line 255 means "not connected"

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 02/10/2016 03:24 AM, Rafael J. Wysocki wrote:
On Tue, Feb 9, 2016 at 5:44 PM, Bjorn Helgaas <helgaas@xxxxxxxxxx> wrote:
On Sat, Feb 06, 2016 at 04:43:14PM +0100, Heiner Kallweit wrote:
Am 06.02.2016 um 16:19 schrieb Bjorn Helgaas:
On Sat, Feb 06, 2016 at 09:09:47AM +0100, Heiner Kallweit wrote:
Am 06.02.2016 um 00:37 schrieb Rafael J. Wysocki:
On Saturday, February 06, 2016 12:00:32 AM Heiner Kallweit wrote:
Since commit a44c386a361e "x86/PCI/ACPI: Recognize that Interrupt Line 255
means "not connected"" I get several "PCI INT not connected" warnings on
a Zotac CI321 and EHCI failes to load:
That doesn't follow clearly from your report, but I'm assuming that it works
correctly without that commit, right?

Right, w/o this commit it looks like this:

dmesg
ehci-pci 0000:00:1d.0: irq 23, io mem 0xf7d1b000

/proc/interrupts
IO-APIC  23-fasteoi   ehci_hcd:usb3
Thanks a lot for your report!  This is a bit of a minefield, and I was
worried that we'd trip over something with a44c386a361e.

Oops, I think I see a problem with a44c386a361e.  We're checking for
Interrupt Line == 255 even before we try to look it up in the _PRT.  I
think we should only check Interrupt Line *after* everything else has
failed.  Can you try the patch below instead of a44c386a361e?

With the attached patch everything is fine. No warnings and EHCI loads properly.
Great, thanks a lot for testing this!

Chen, will you update and repost your patch?  I know Rafael already
had it on a branch, but I think he dropped it, so we need to get the
update merged somehow.
I'd prefer a new updated patch if that's possible.
patch is coming soon, thank all of your help.

Chen

Thanks,
Rafael






--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux