On Monday 08 February 2016 12:43:58 Joao Pinto wrote: > This patch goal is to centralize in pcie-designware the link up > validation. A new function was added to pci-designware that is > responsible for doing such a task. This was implemented in a form that > permits flexibility for all SoCs. > > Signed-off-by: Joao Pinto <jpinto@xxxxxxxxxxxx> I believe the different timeouts in each driver are just coincidence and partly based on who reviewed which driver. I'm pretty sure it doesn't really matter at all, and we can just use the same loop for every one. I was also hoping that a little more than just the loop could be unified between the various establish_link() functions. I have a feeling that each one just implements a subset of what is actually required, so they are buggy in different ways because nobody has the datasheet. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html