> -----Original Message----- > From: David Woodhouse [mailto:dwmw2@xxxxxxxxxxxxx] > Sent: Thursday, January 21, 2016 4:33 PM > To: Bjorn Helgaas <helgaas@xxxxxxxxxx> > Cc: Lawrynowicz, Jacek <jacek.lawrynowicz@xxxxxxxxx>; Alex Williamson > <alex.williamson@xxxxxxxxxx>; linux-pci@xxxxxxxxxxxxxxx; > bhelgaas@xxxxxxxxxx; jroedel@xxxxxxx > Subject: Re: [PATCH] pci: Add support for multiple DMA aliases > > On Thu, 2016-01-21 at 09:22 -0600, Bjorn Helgaas wrote: > > > > This definitely isn't part of the driver code; I didn't mean to > > suggest that. I'd like to see this as a separate patch, but as part > > of a series that adds a user of the multiple-alias functionality. > > > > All I'm saying is that as-is, this patch makes the quirks easier to > > read but doesn't actually change any behavior: we set up at most one > > alias, and we do it as a header quirk at enumeration-time, so there > > are no new lifetime issues. Normally we merge things when they're > > needed, and multiple alias support is a bit of infrastructure that > > isn't used yet. > > Ah, right. I see your point. > > I don't actually see why pci_add_dma_alias() should be exported at all. > > I suspect the best approach is for Jacek to add a second patch in this > series, adding the required quirk to drivers/pci/quirks.c for the > device in question, and then resubmit them to you when Linus releases > 4.5-rc1. > > This is completely independent of any native driver for the device, of > course. OK guys, I've prepared a second version of the patch that includes fixes for all your review comments. I will post it today to linux-pci. It also includes a quirk for x200 dma driver that is undergoing internal review and will be posted to dma tree probably early next week. It would be great if v2 could be included in 4.5 but I understand that it's a bit late and you may prefer to wait for x200 dma driver to be posted. Thanks for all your feedback. The patch now make a lot more sense. Regards, Jacek -- Jacek Lawrynowicz Intel Technology Poland sp. z o.o. KRS 101882 - ul. Slowackiego 173, 80-298 Gdansk
Attachment:
smime.p7s
Description: S/MIME cryptographic signature
