On Tuesday 10 November 2015 09:41:18 Lucas Stach wrote: > > diff --git a/drivers/pci/host/pci-imx6.c b/drivers/pci/host/pci-imx6.c > > index 233a196..9769b13 100644 > > --- a/drivers/pci/host/pci-imx6.c > > +++ b/drivers/pci/host/pci-imx6.c > > @@ -499,7 +499,7 @@ static int imx6_pcie_link_up(struct pcie_port *pp) > > * Wait a little bit, then re-check if the link finished > > * the training. > > */ > > - usleep_range(1000, 2000); > > + mdelay(1000); > > A mdelay(1000) is a whole different timescale than a usleep(1000). If > this patch works for you with mdelay(1) or maybe mdelay(2) I would be > fine with it. mdelay(1) is still a really long time to block the CPU for, on potentially every config space access. Everybody else just returns the link status here, which seems to be the better alternative. If you need to delay the startup, better have a msleep(1) loop in the initial probe function where you are allowed to sleep. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
