Hi Gab, On Thu, Sep 10, 2015 at 8:28 PM, Gabriele Paoloni <gabriele.paoloni@xxxxxxxxxx> wrote: > From: gabriele paoloni <gabriele.paoloni@xxxxxxxxxx> > > Currently spear13xx passes the wrong "address" in many calls to > dw_pcie_cfg_read and dw_pcie_cfg_write: the passed address is > always pp->dbi_base, that is wrong as it does not consider > the offset to access the right register of the PCI header. > This patches fixes these function calls passing the address to > access the right register. Thanks for the effort, however there were some more issues with current implementation. Like PCI_EXP_DEVCTL is only two bytes of register. Next two bytes are PCI_EXP_DEVSTS which is RO, so writing 4 bytes at offset 'exp_cap_off + PCI_EXP_DEVCTL' is not correct. I had sent a patch to correct all the issues with current implementation [1]. You can take that as your 1st patch. [1] https://lkml.org/lkml/2015/9/7/5 -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
