Hi Pratyush, many thanks for replying. > -----Original Message----- > From: Pratyush Anand [mailto:pratyush.anand@xxxxxxxxx] > Sent: Tuesday, September 08, 2015 10:06 AM > To: Gabriele Paoloni > Cc: Jingoo Han; Wangzhou (B); linux-pci@xxxxxxxxxxxxxxx; qiuzhenfa; > zhangjukuo; liudongdong (C); Liguozhu (Kenneth); qiujiang > Subject: Re: [PATCH] PCI: Designware: Move num-lanes property read to > dw_pcie_setup_rc > > Hi Gab, > > Sorry for the delayed response. > > On Wed, Aug 26, 2015 at 4:44 PM, Gabriele Paoloni > <gabriele.paoloni@xxxxxxxxxx> wrote: > > From: gabriele paoloni <gabriele.paoloni@xxxxxxxxxx> > > > > Currently num-lanes is read in dw_pcie_host_init(). > > for A SoC that performs the link-up operation in UEFI num-lanes > > is not needed in the DTS but it has to be specified to any value; > > otherwise dw_pcie_host_init will fail. > > OK, So it means num-lanes is no longer "required property" and can be > an "optional property". > IMO, > > * move num-lanes from "Required" to "Optional" in > Documentation/devicetree/bindings/pci/designware-pcie.txt Agreed, will do in PATCH v2 > * Handle it in dw_pcie_host_init() itself (similar to bus-range) > - s/dev_err/dev_dbg > - set pp->lanes = 0; > * May be we can put a dev_err message in dw_pcie_setup_rc() for pp- > >lanes = 0. > About these two above, moving the DT read to dw_pcie_setup_rc() would save the hassle of setting pp->lanes to 0 and having it checked later in dw_pcie_setup_rc(), however if you think it is more clean to keep all the DT related part in dw_pcie_host_init() I have no probs in doing the way you suggested... > ~Pratyush ��.n��������+%������w��{.n�����{���"�)�� jg��� �����ݢj����G���� ���j:+v���w�m������w�������h�����٥
