Re: [PATCH] PCI: Designware: Move num-lanes property read to dw_pcie_setup_rc

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Gab,

Sorry for the delayed response.

On Wed, Aug 26, 2015 at 4:44 PM, Gabriele Paoloni
<gabriele.paoloni@xxxxxxxxxx> wrote:
> From: gabriele paoloni <gabriele.paoloni@xxxxxxxxxx>
>
> Currently num-lanes is read in dw_pcie_host_init().
> for A SoC that performs the link-up operation in UEFI num-lanes
> is not needed in the DTS but it has to be specified to any value;
> otherwise dw_pcie_host_init will fail.

OK, So it means num-lanes is no longer "required property" and can be
an "optional property".
IMO,

* move num-lanes from "Required" to "Optional" in
Documentation/devicetree/bindings/pci/designware-pcie.txt
* Handle it in dw_pcie_host_init() itself (similar to bus-range)
     - s/dev_err/dev_dbg
     - set pp->lanes = 0;
* May be we can put a dev_err message in dw_pcie_setup_rc() for pp->lanes = 0.

~Pratyush
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux