On Wed, Nov 26, 2014 at 05:55:05PM +0100, Arnd Bergmann wrote: > On Wednesday 26 November 2014 17:21:37 Thierry Reding wrote: > > - > > + pci_add_resource_offset(&sys->resources, &pcie->pio, sys->io_offset); > > pci_add_resource_offset(&sys->resources, &pcie->mem, sys->mem_offset); > > pci_add_resource_offset(&sys->resources, &pcie->prefetch, > > sys->mem_offset); > > > > You don't set sys->io_offset anywhere, which is a bug if you have multiple > instances of the PCI host in one system. In my draft patch, I was setting > both io_offset and mem_offset for consistency, and while mem_offset would > in practice be always zero (as discussed on IRC), the io_offset in fact has > a realistic chance of being nonzero and you should definitely set it. I was going to do that in a follow-up patch since it isn't needed to fix this particular regression. Thierry
Attachment:
pgpyI9V8dQyCR.pgp
Description: PGP signature
