> -----Original Message----- > From: Lucas Stach [mailto:l.stach@xxxxxxxxxxxxxx] > Sent: Tuesday, October 21, 2014 4:18 PM > To: Richard Zhu > Cc: linux-pci@xxxxxxxxxxxxxxx; Guo Shawn-R65073; festevam@xxxxxxxxx; > tharvey@xxxxxxxxxxxxx; m-karicheri2@xxxxxx > Subject: Re: [PATCH v8]PCI: imx6: enable pcie on imx6sx sdb and imx6qdl > sabreauto. > > Am Montag, den 20.10.2014, 13:25 +0800 schrieb Richard Zhu: > > Main changes since the v6(v7 is ignored): > > 1. Regarding to Lucas' suggestion, assert per-reset in suspend, and > > de-assert it in resume. > > 2. Use pp->ops->get_msi_data in dw_pcie_msi_cfg_restore() if there is > > one get_msi_data pp ops callback, refer to Muali's comment. > > 3. In order to avoid the compilation, squash imx6 changes with > > patch2-5 of v6, since the prototype of the host_init is changed. > > No, this isn't what I wanted. This is completely separate change and needs to > be in one patch. > [Richard] Do you mean the following? * imx6sx pcie support to be one patch. * the prototype of the host_init changes should be squashed into one standalone patch. > But to move this patchset forward without keeping those endless loops back and > forth between us both let's turn the thing around: I will take most of your > patches (namely the ones adding imx6sx support) and rework them so they look > good to me. I'll send them to you so you can test them on your hardware and > after that send them to the list for inclusion. > > I'll leave out the purely DTS changes, as those are separate hardware > enablement patches, that don't strictly need to be in this series. > > Regards, > Lucas > > -- > Pengutronix e.K. | Lucas Stach | > Industrial Linux Solutions | http://www.pengutronix.de/ | Best Regards Richard Zhu ��.n��������+%������w��{.n�����{���"�)�� jg��� �����ݢj����G���� ���j:+v���w�m������w�������h�����٥
