> -----Original Message----- > From: Fabio Estevam [mailto:festevam@xxxxxxxxx] > Sent: Friday, October 10, 2014 10:55 PM > To: Richard Zhu > Cc: linux-pci@xxxxxxxxxxxxxxx; Guo Shawn-R65073; Lucas Stach; Tim Harvey; Zhu > Richard-R65037 > Subject: Re: [PATCH v5 4/9] PCI: imx6: add imx6sx pcie support > > On Fri, Oct 10, 2014 at 2:41 AM, Richard Zhu <richard.zhu@xxxxxxxxxxxxx> wrote: > > > static void imx6_pcie_init_phy(struct pcie_port *pp) { > > struct imx6_pcie *imx6_pcie = to_imx6_pcie(pp); > > + int ret; > > + > > + /* Power up the separate domain available on i.MX6SX */ > > + if (is_imx6sx_pcie(imx6_pcie)) { > > + /* Force PCIe PHY reset */ > > + regmap_update_bits(imx6_pcie->iomuxc_gpr, IOMUXC_GPR5, > > + IMX6SX_GPR5_PCIE_BTNRST, > > + IMX6SX_GPR5_PCIE_BTNRST); > > + > > + regmap_update_bits(imx6_pcie->gpc_ips_reg, GPC_CNTR, > > + GPC_CNTR_PCIE_PHY_PUP_REQ, > > + GPC_CNTR_PCIE_PHY_PUP_REQ); > > + regulator_set_voltage(imx6_pcie->pcie_phy_regulator, > > + 1100000, 1100000); > > + ret = regulator_enable(imx6_pcie->pcie_phy_regulator); > > + if (ret) > > + dev_info(pp->dev, "failed to enable pcie > > + regulator.\n"); > > You should 'return ret' in the case of error. [Richard] Ok. Best Regards Richard Zhu ��.n��������+%������w��{.n�����{���"�)�� jg��� �����ݢj����G���� ���j:+v���w�m������w�������h�����٥
