On Sun, Aug 17, 2014 at 8:29 AM, Yinghai Lu <yinghai@xxxxxxxxxx> wrote: > On Sat, Aug 16, 2014 at 6:13 AM, Pratyush Anand > <pratyush.anand@xxxxxxxxx> wrote: >> On Wed, Jul 23, 2014 at 11:22 PM, Lucas Stach <l.stach@xxxxxxxxxxxxxx> wrote: >> >> I am not sure here. IIRC, then calling pci_assign_unassigned_resources after >> pci_common_init_dev was needed to handle few PCIe cards with EP behind >> bridge. >> >> I do not have good understanding of pci resource allocation code. >> @Yinghai: Can you please help(rather teach) with the description of >> different resource allocator >> available in setup-bus.c. Can try reading code, but if a documentation >> exists, that would >> be helpful. > > pci_assign_unassigned_resources() should try several times to make sure > assign resource to PCI bars that are not assigned by BIOS or not valid value > from BIOS. > so it will honor the setting from BIOS. > > in your arm case, pci_common_init_dev() is doing sizing and assign. > so you should not need that pci_assign_unassigned_resources() anymore. > > Or your setup have PCI_PROBE_ONLY ? Thanks for the clarification. I think none of the designware based platform boots with *firmware*, so none of the setup should have PCI_PROBE_ONLY. Then patch seems fine. ~Pratyush > > Yinghai -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
