On Wed, Jul 23, 2014 at 11:22 PM, Lucas Stach <l.stach@xxxxxxxxxxxxxx> wrote: > The pci_common_init_dev() call right before will already > handle the device resource allocation, so this call > was a no-op. > > Signed-off-by: Lucas Stach <l.stach@xxxxxxxxxxxxxx> > --- > drivers/pci/host/pcie-designware.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/pci/host/pcie-designware.c b/drivers/pci/host/pcie-designware.c > index b869e202367c..dde5e6d4afa2 100644 > --- a/drivers/pci/host/pcie-designware.c > +++ b/drivers/pci/host/pcie-designware.c > @@ -568,7 +568,6 @@ int __init dw_pcie_host_init(struct pcie_port *pp) > dw_pci.private_data = (void **)&pp; > > pci_common_init_dev(pp->dev, &dw_pci); > - pci_assign_unassigned_resources(); I am not sure here. IIRC, then calling pci_assign_unassigned_resources after pci_common_init_dev was needed to handle few PCIe cards with EP behind bridge. I do not have good understanding of pci resource allocation code. @Yinghai: Can you please help(rather teach) with the description of different resource allocator available in setup-bus.c. Can try reading code, but if a documentation exists, that would be helpful. ~Pratyush -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
