On Wed, Aug 06, 2014 at 11:59:39AM +0200, Borislav Petkov wrote: > > Bjorn ever mentioned for this: > > "I'd like to see all those "BIT(...)" things changed to use the #defines > > that already exist in include/uapi/linux/pci_regs.h, e.g., > > PCI_ERR_COR_RCVR. That way grep will find these uses, which will make > > maintenance easier." > > So explain that in the commit message but don't use some bits out of > context. > > In general, when you read your own commit message, always ask yourself > whether other people will be able to understand it, long time from now > and out of context. > > If yes, only then send out the patch. > Copy that. Thx a lot!
Attachment:
signature.asc
Description: Digital signature
