On Wed, Aug 06, 2014 at 11:32:23AM +0200, Borislav Petkov wrote: > Date: Wed, 6 Aug 2014 11:32:23 +0200 > From: Borislav Petkov <bp@xxxxxxxxx> > To: "Chen, Gong" <gong.chen@xxxxxxxxxxxxxxx> > Cc: bhelgaas@xxxxxxxxxx, rdunlap@xxxxxxxxxxxxx, tony.luck@xxxxxxxxx, > linux-pci@xxxxxxxxxxxxxxx > Subject: Re: [PATCH 1/5] RAS, trace: Update error definition format > User-Agent: Mutt/1.5.23 (2014-03-12) > > On Wed, Aug 06, 2014 at 04:32:40AM -0400, Chen, Gong wrote: > > Previous format definition uses MACRO BIT(...), which is not very > > maintainable. > > What does that "not very maintainable" mean? > Bjorn ever mentioned for this: "I'd like to see all those "BIT(...)" things changed to use the #defines that already exist in include/uapi/linux/pci_regs.h, e.g., PCI_ERR_COR_RCVR. That way grep will find these uses, which will make maintenance easier."
Attachment:
signature.asc
Description: Digital signature
